Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc QA fixes for review #1

Merged
merged 4 commits into from Nov 6, 2011
Merged

Misc QA fixes for review #1

merged 4 commits into from Nov 6, 2011

Conversation

CloCkWeRX
Copy link
Member

So; with Jenkins now available - how do we feel about phpunit 3.6, a build.xml (implying ant), dropping AllTests, etc?

@till
Copy link
Member

till commented Nov 6, 2011

I don't mind either. Maybe we can pre-process this before the job runs?

Pull request looks good: +1

@cweiske
Copy link
Member

cweiske commented Nov 6, 2011

I'd rather use phing than ant, but I'm ok with dropping alltests (as long as we have something that pear can use with run-tests )

@CloCkWeRX
Copy link
Member Author

@till - when you say preprocess; what do you mean?
@cweiske - pear run-tests supports phpunit AllTests out of the box? Or at least can be told "pear run-tests tests/AllTests.php" and have it treat it like a normal PHP file? What does it do with the results?

CloCkWeRX added a commit that referenced this pull request Nov 6, 2011
Misc QA fixes for review
@CloCkWeRX CloCkWeRX merged commit 6c339be into pear:master Nov 6, 2011
@till
Copy link
Member

till commented Nov 6, 2011

@CloCkWeRX: I mean, I wouldn't go through all packages and delete AllTests.php now. I'd tell people it's not necessary anymore so new packages don't do it or current packages can update when they get around to it.

Also, I'd probably try to leverage a phpunit.xml (somehow) because it makes bootstrapping tests with phpunit very simple.

Generally, I'm not sure how jenkins is being setup, but maybe that part would just do whatever is necessary to run tests.

@CloCkWeRX
Copy link
Member Author

@till - I agree - I've been doing two main types of jobs.

  1. phpunit --with-lots -of flags tests/[AllTests.php if needed]
  2. build.xml + phpunit.xml when there are external libraries; and the jenkins build has ~3+ custom commands to manage it.

@cweiske
Copy link
Member

cweiske commented Nov 7, 2011

Hello Daniel,

@till - when you say preprocess; what do you mean?
@cweiske - pear run-tests supports phpunit AllTests out of the box?
Or at least can be told "pear run-tests tests/AllTests.php" and have
it treat it like a normal PHP file? What does it do with the results?

See http://pear.php.net/bugs/bug.php?id=10834
and http://pear.php.net/bugs/bug.php?id=11883
which implemented phpunit alltests support

Regards/Mit freundlichen Grüßen
Christian Weiske

-=≡ Geeking around in the name of science since 1982 ≡=-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants